This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: new pass to warn on questionable uses of alloca() and VLAs
On 19 July 2016 at 18:47, Jeff Law <law@redhat.com> wrote:
> On 07/17/2016 09:52 AM, Manuel López-Ibáñez wrote:
>>
>> + if (is_vla)
>> + gcc_assert (warn_vla_limit > 0);
>> + if (!is_vla)
>> + gcc_assert (warn_alloca_limit > 0);
>>
>> if-else ? Or perhaps:
>
> Shouldn't really matter, except perhaps in a -O0 compilation. Though I
> think else-if makes it slightly clearer.
Of course, I mentioned it because of clarity. It was difficult to
distinguish !i versus (i in my screen and I had to stop to read it
again.
Cheers,
Manuel.