This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Amend dump expectation in slsr-8.c (PR, tree-optimization/71490)
On 07/14/2016 01:21 PM, Richard Biener wrote:
> On Thu, Jul 14, 2016 at 1:06 PM, Martin Liška <mliska@suse.cz> wrote:
>> On 07/13/2016 07:21 PM, Jeff Law wrote:
>>> Isn't that a code quality regression? So instead shouldn't we be keeping the same expectation, but xfailing the test?
>>>
>>> jeff
>>
>> Hello.
>>
>> Disabling a pass before slsr makes the test to catch both opportunities.
>> Is the patch fine?
>
> No, this is still a code quality regression. What happens is that for
> some reason we fail to sink for GCC 6.
So should I just mark the test-case as a xfail?
M.
>
> Richard.
>
>> Thanks,
>> Martin