This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)

From: Marek Polacek <polacek at redhat dot com>
To: Martin Sebor <msebor at gmail dot com>
Cc: Manuel López-Ibáñez <lopezibanez at gmail dot com>, David Malcolm <dmalcolm at redhat dot com>, Florian Weimer <fweimer at redhat dot com>, Jakub Jelinek <jakub at redhat dot com>, Gcc Patch List <gcc-patches at gcc dot gnu dot org>, Joseph Myers <joseph at codesourcery dot com>, Richard Biener <rguenther at suse dot de>
Date: Wed, 13 Jul 2016 10:18:28 +0200
Subject: Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)
Authentication-results: sourceware.org; auth=none
References: <5776B33E.2080504@gmail.com> <6eb7cd2c-b7ae-ae84-f00e-40283c9fda84@redhat.com> <20160712095426.GZ7387@tucnak.redhat.com> <3d4b71a1-5cfc-dbb7-e2a2-88c15b401407@redhat.com> <5785028B.4040508@gmail.com> <1468335679.13104.31.camel@redhat.com> <578513D2.7050904@gmail.com> <578516FA.1050707@gmail.com> <578570C6.50107@gmail.com>

On Tue, Jul 12, 2016 at 04:35:50PM -0600, Martin Sebor wrote:
> Based on the gcc.pot file it does look like quoted numbers are
> far less common than unquoted ones (just 10 messages where they
> are quoted vs 528 unquoted).
> 
> I've added this as a guideline to the Wiki and assuming no one
> suggests otherwise I'll remove the quotes from this patch and
> from the other changes I already committed.

I will support the change as I don't see any need for quoting numbers,
as opposed to e.g. identifiers.

	Marek

References:
- [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)
  - From: Martin Sebor
- Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)
  - From: Florian Weimer
- Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)
  - From: Jakub Jelinek
- Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)
  - From: Florian Weimer
- Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)
  - From: Martin Sebor
- Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)
  - From: David Malcolm
- Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)
  - From: Martin Sebor
- Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)
  - From: Manuel López-Ibáñez
- Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)
  - From: Martin Sebor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]