This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, rs6000] Fix PR71297 (ICE on invalid calls to vec_ld and vec_st)


Fixed in trunk with r238168, test case included.  Thanks!

Bill

> On Jul 8, 2016, at 7:29 AM, Bill Schmidt <wschmidt@linux.vnet.ibm.com> wrote:
> 
>> 
>> On Jul 8, 2016, at 12:14 AM, Segher Boessenkool <segher@kernel.crashing.org> wrote:
>> 
>> On Thu, Jul 07, 2016 at 03:40:28PM -0500, Bill Schmidt wrote:
>>>> PR71297 reports that we ICE when __builtin_vec_ld or __builtin_vec_st is
>>>> provided with an incorrect number of arguments.  This patch fixes it by
>>>> bypassing special handling for these intrinsics when the number of
>>>> arguments is wrong, thus allowing the standard error handling for
>>>> builtins to kick in.
>>>> 
>>>> The patch is pretty obvious and I think adding a test case would be
>>>> extraneous, though I can do so if desired.
>> 
>> Well you could use the one from the PR?
>> 
>>>> Bootstrapped and tested on
>>>> powerpc64le-unknown-linux-gnu with no regressions, and the original
>>>> failure is fixed.  Is this ok for trunk?
>> 
>> Yes, but please do a testcase.  Okay for backports, too.
> 
> No backports required; this is a 7 regression.
> 
> Bill
> 
>> 
>> 
>> Segher
>> 
>> 
>>>> 	PR target/71297
>>>> 	* config/rs6000/rs6000-c.c (altivec_resolve_overloaded_builtin):
>>>> 	Allow standard error handling to take over when a wrong number
>>>> 	of arguments is presented to __builtin_vec_ld () or
>>>> 	__builtin_vec_st ().


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]