This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v2] Allocate constant size dynamic stack space in the prologue
- From: Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>
- To: vogt at linux dot vnet dot ibm dot com, Jeff Law <law at redhat dot com>, gcc-patches at gcc dot gnu dot org, Ulrich Weigand <Ulrich dot Weigand at de dot ibm dot com>, Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
- Date: Mon, 4 Jul 2016 16:08:34 +0200
- Subject: Re: [PATCH v2] Allocate constant size dynamic stack space in the prologue
- Authentication-results: sourceware.org; auth=none
- References: <20151125125610.GA19687@linux.vnet.ibm.com> <20160506093747.GA22977@linux.vnet.ibm.com> <20160506094415.GA23043@linux.vnet.ibm.com> <03ecb4c1-3d2f-0ff7-1110-7519a5106d5a@redhat.com> <20160623154814.GA23280@linux.vnet.ibm.com> <20160624123044.GA12401@linux.vnet.ibm.com> <20160704121955.GA9654@linux.vnet.ibm.com>
On 07/04/2016 02:19 PM, Dominik Vogt wrote:
> Version 4 with the following change:
>
> * Rebased on top of the "Minor cleanup to
> allocate_dynamic_stack_space" patch. The "Drop excess size
> used for run time allocated stack variables." path needs an
> update because it touches the dsame code as the patch in this
> message.
>
> Ran the testsuite on s390x biarch, s390 and x86_64.
>
> On Fri, Jun 24, 2016 at 01:30:44PM +0100, Dominik Vogt wrote:
>>> The only open question I'm aware of is the
>>> stack-usage-2.c test. I guess foo3() will not generate
>>>
>>> stack usage might be ... bytes
>>>
>>> On any target anymore, and using alloca() with a constant size
>>> results in "unbounded". It's unclear to me whether that message
>>> is ever generated, and if so, how to trigger it.
>
> This point is still open. If nobody has more comments Andreas
> will commit the (afaik already approved) patch soon and we can
> clean up the test case in a follow up patch.
I would like to see an explicit approval before doing the commit. I think it would also make sense
to let other target maintainers have a look whether this might cause any problems.
Bye,
-Andreas-
>
> Ciao
>
> Dominik ^_^ ^_^
>