This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] check initializer to be zero in .bss-like sections


>>> On 01.07.16 at 15:36, <bschmidt@redhat.com> wrote:
> On 07/01/2016 10:21 AM, Jan Beulich wrote:
>> Just like gas, which has recently learned to reject such initializers,
>> gcc shouldn't accept such either.
>> ---
>> v2: Use dg-require-named-sections.
>>
>> gcc/
>> 2016-07-01  Jan Beulich  <jbeulich@suse.com>
>>
>> 	* varasm.c (get_variable_section): Validate initializer in
>> 	named .bss-like sections.
>>
>> gcc/testsuite/
>> 2016-07-01  Jan Beulich  <jbeulich@suse.com>
>>
>> 	* gcc.dg/bss.c: New.
> 
> Looks ok, except why the empty dg-options string in the testcase?

Because I've seen in it that way in various other test cases (and
yes, yet others don't have it). I had to decide for one of the
variants, and if it's not required (nor wanted) I can certainly drop
it.

Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]