This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, rs6000] Enable some existing __float128 tests for powerpc64*


On Thu, 30 Jun 2016, Bill Schmidt wrote:

> On Wed, 2016-06-29 at 16:37 +0000, Joseph Myers wrote:
> > On Tue, 28 Jun 2016, Bill Schmidt wrote:
> > 
> > > -/* { dg-do compile { target ia64-*-* i?86-*-* x86_64-*-* } } */
> > > +/* { dg-do compile { target ia64-*-* i?86-*-* x86_64-*-* powerpc64*-*-* } } */
> > >  /* { dg-options "-pedantic" } */
> > > +/* { dg-additional-options "-mfloat128 -mvsx" { target powerpc64*-*-* } } */
> > 
> > Rather than duplicating powerpc64 references everywhere, wouldn't it be 
> > better to add an effective-target keyword __float128, meaning that 
> > __float128 is available?  Along with { dg-add-options float128 }.
> 
> Sure, I can do that.  I guess I need to stay away from the name
> check_effective_target_float128, though, as in your pending patch that
> will mean availability of _Float128.  Do you have a naming preference?

My suggestion is check_effective_target___float128, so __float128 is the 
effective-target keyword.  (You don't need separate naming for the 
dg-add-options case, since the same options will work for both __float128 
and _Float128.)

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]