This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, testsuite]: More fixes in vect testsuite
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Christophe Lyon <christophe dot lyon at linaro dot org>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jakub Jelinek <jakub at redhat dot com>
- Date: Fri, 24 Jun 2016 18:34:11 +0200
- Subject: Re: [PATCH, testsuite]: More fixes in vect testsuite
- Authentication-results: sourceware.org; auth=none
- References: <CAFULd4bcXc_aJuno=x0+9-6ZDU8=iRcakQ-WnfKnE3PUjapTjA at mail dot gmail dot com> <CAKdteOZBqqDZH7pTsoCKaJmhzq8tvQ_D4mKC7iT5k8Cgshcaug at mail dot gmail dot com>
2016-06-24 18:14 GMT+02:00 Christophe Lyon <christophe.lyon@linaro.org>:
> 2016-06-24 17:50 GMT+02:00 Uros Bizjak <ubizjak@gmail.com>:
>> Hello!
>>
>> - Remove harmful "dg-do run" directives (run vs. compile is handled
>> automatically by the vect.exp infrastructure)
>
> I thought Jakub disagreed on that :-)
Please see this snippet from check_vect_support_and_set_flags,
lib/target-supports.exp:
} elseif { [istarget i?86-*-*] || [istarget x86_64-*-*] } {
lappend DEFAULT_VECTCFLAGS "-msse2"
if { [check_effective_target_sse2_runtime] } {
set dg-do-what-default run
} else {
set dg-do-what-default compile
}
So, "dg-do run" will overwrite this and vect.exp will run the testcase
on targets that are not sse2 capable. We do have check_vect as a
safety net, but running the executable in this case is just pointless.
Please also note that check_effective_target_sse2_runtime checks that
the assembler is capable of assembling SSE2 instructions, and will
prevent assembling and linking failure.
I'd like to point out, that "dg-do compile" directives remain in the testcases.
Uros.