This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: AW: [PATCH] Add a new target hook to compute the frame layout

From: Jeff Law <law at redhat dot com>
To: Bernd Edlinger <bernd dot edlinger at hotmail dot de>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Cc: Richard Biener <rguenther at suse dot de>, Jakub Jelinek <jakub at redhat dot com>, Richard Sandiford <rdsandiford at googlemail dot com>, Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>
Date: Wed, 22 Jun 2016 12:34:38 -0600
Subject: Re: AW: [PATCH] Add a new target hook to compute the frame layout
Authentication-results: sourceware.org; auth=none
References: <AM4PR0701MB2162FA0509CEF1A1D865EB0FE4560 at AM4PR0701MB2162 dot eurprd07 dot prod dot outlook dot com> <538a413b-ef74-4a9a-1665-f3b84a8d9035 at redhat dot com> <AM4PR0701MB21629D9855D4056F810BB4F8E42C0 at AM4PR0701MB2162 dot eurprd07 dot prod dot outlook dot com> <AM4PR0701MB2162EBD176C738F44E39426BE42C0 at AM4PR0701MB2162 dot eurprd07 dot prod dot outlook dot com>

On 06/22/2016 01:20 AM, Bernd Edlinger wrote:

On 06/21/16 23:29, Jeff Law wrote:


How does this macro interact with INITIAL_FRAME_POINTER_OFFSET?


That I forgot to mention:  INITIAL_FRAME_POINTER_OFFSET is just
a single call, so whenever it is called from lra/reload the frame layout
is really expected to change, and so it does not make a difference if the target
computes the frame layout in TARGET_COMPUTE_FRAME_LAYOUT or in
INITIAL_FRAME_POINTER_OFFSET.

But I do not know of any targets that still use INITIAL_FRAME_POINTER_OFFSET,
and maybe support for this target hook could be discontinued as a follow-up patch.

INITIAL_FRAME_POINTER_OFFSET is only defined in 4 ports:

./ft32/ft32.h:#define INITIAL_FRAME_POINTER_OFFSET(DEPTH) (DEPTH) = 0
./m32r/m32r.h:#define INITIAL_FRAME_POINTER_OFFSET(VAR) \
./moxie/moxie.h:#define INITIAL_FRAME_POINTER_OFFSET(DEPTH) (DEPTH) = 0
./vax/vax.h:#define INITIAL_FRAME_POINTER_OFFSET(DEPTH) (DEPTH) = 0;

However, the m32r version is actually #if 0'd out. So it's really onlydefined in 3 ports and always to "0". So yea, it'd be a good candidateto collapse away.


Jeff

References:
- [PATCH] Add a new target hook to compute the frame layout
  - From: Bernd Edlinger
- Re: [PATCH] Add a new target hook to compute the frame layout
  - From: Jeff Law
- Re: [PATCH] Add a new target hook to compute the frame layout
  - From: Bernd Edlinger
- AW: [PATCH] Add a new target hook to compute the frame layout
  - From: Bernd Edlinger

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]