This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [openacc] clean up acc directive matching in fortran
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Tobias Burnus <tobias dot burnus at physik dot fu-berlin dot de>
- Cc: Cesar Philippidis <cesar_philippidis at mentor dot com>, gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
- Date: Fri, 17 Jun 2016 16:07:24 +0200
- Subject: Re: [openacc] clean up acc directive matching in fortran
- Authentication-results: sourceware.org; auth=none
- References: <57636F15 dot 3030509 at mentor dot com> <20160617084040 dot GA15605 at physik dot fu-berlin dot de>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Jun 17, 2016 at 10:40:40AM +0200, Tobias Burnus wrote:
> Cesar Philippidis wrote:
> > On 06/16/2016 08:30 PM, Cesar Philippidis wrote:
> > > This patch introduces a match_acc function to the fortran FE. It's
> > > almost identical to match_omp, but it passes openacc = true to
> > > gfc_match_omp_clauses. I supposed I could have consolidated those two
> > > functions, but they are reasonably simple so I left them separate. Maybe
> > > a follow up patch can consolidate them. I was able to eliminate a lot of
> > > duplicate code with this function.
> > >
> > > Is this ok for trunk and gcc-6?
>
> > And here's the patch.
>
> The patch seems to be reverse. If I regard the "-" lines as additions
> and the "+" lines as deletions, it makes sense and is in line with
> the ChangeLog and what you wrote above.
>
> Otherwise, it looks good to me.
Yeah, patch -R + commit is ok with me.
Jakub