This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] Implement is_[nothrow_]swappable (p0185r1) - 2nd try
- From: Daniel KrÃgler <daniel dot kruegler at gmail dot com>
- To: Jonathan Wakely <jwakely at redhat dot com>
- Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 16 Jun 2016 20:21:57 +0200
- Subject: Re: [Patch] Implement is_[nothrow_]swappable (p0185r1) - 2nd try
- Authentication-results: sourceware.org; auth=none
- References: <CAGNvRgC6o2WcX_JZC-wHysnSzz0rnnss+9L=exf_FvXFtP-Etw at mail dot gmail dot com> <CAGNvRgAixfQTsOjy9vU0Q_VxvZBvY7OZd=qxJ7062-sB=ZzUxQ at mail dot gmail dot com> <20160616130056 dot GU11538 at redhat dot com> <20160616130148 dot GV11538 at redhat dot com> <20160616130855 dot GW11538 at redhat dot com> <20160616150759 dot GY11538 at redhat dot com>
2016-06-16 17:07 GMT+02:00 Jonathan Wakely <jwakely@redhat.com>:
> On 16/06/16 14:08 +0100, Jonathan Wakely wrote:
>>
>>
>> /home/jwakely/src/gcc/gcc/libstdc++-v3/testsuite/20_util/is_nothrow_swappable/./value.h:285:3:
>> error: static assertion failed
>>
>> /home/jwakely/src/gcc/gcc/libstdc++-v3/testsuite/20_util/is_nothrow_swappable/./value.h:287:3:
>> error: static assertion failed
>>
>> /home/jwakely/src/gcc/gcc/libstdc++-v3/testsuite/20_util/is_nothrow_swappable/./value.h:289:3:
>> error: static assertion failed
>>
>> Those assertions fail for both 20_util/is_nothrow_swappable/value.cc
>> and 20_util/is_nothrow_swappable/value_ext.cc
>
>
> Those assertions should be changed because with your patch queue,
> priority_queue and stack are nothrow swappable, because they don't
> depend on the value_type's swappable trait, but the sequence's.
Yes, I agree.
> The other problems are that some tests need their dg-error lines
> adjusting, and <type_traits> says #ifdef __cplusplus >= 201402L which
> should be #if.
OK.
Thanks again for your patience to test the whole mess!
- Daniel