This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Handle undefined extern vars in output_in_order
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Alexander Monakov <amonakov at ispras dot ru>
- Cc: Jan Hubicka <hubicka at ucw dot cz>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 16 Jun 2016 17:42:40 +0200
- Subject: Re: [PATCH] Handle undefined extern vars in output_in_order
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot LNX dot 2 dot 20 dot 1606091554200 dot 19352 at monopod dot intra dot ispras dot ru> <alpine dot LNX dot 2 dot 20 dot 1606161659170 dot 16817 at monopod dot intra dot ispras dot ru> <20160616142524 dot GA93274 at kam dot mff dot cuni dot cz> <alpine dot LNX dot 2 dot 20 dot 1606161733020 dot 16817 at monopod dot intra dot ispras dot ru> <20160616152403 dot GA38925 at kam dot mff dot cuni dot cz> <alpine dot LNX dot 2 dot 20 dot 1606161826460 dot 16817 at monopod dot intra dot ispras dot ru>
> On Thu, 16 Jun 2016, Jan Hubicka wrote:
> > I see, order is created at a time variable is added to symbol table (not at
> > time when definition is given). So we should have order everywhere.
> > Patch is OK
>
> Thanks! If you don't mind a quick followup question: now that both
> FOR_EACH_VARIABLE loops in two functions have the same structure, is
> it alright to add a comment of the form
>
> /* There is a similar loop in output_in_order. Please keep them in sync. */
>
> to symbol_table::output_variables, and vice versa?
Yes, that is fine.
Honza