This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [BUILDROBOT] MPS430 build problem due to new enum (was: [PATCH 2/2] Add edge predictions pruning)
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Jan-Benedict Glaw <jbglaw at lug-owl dot de>
- Cc: Martin Liška <mliska at suse dot cz>, Jan Hubicka <hubicka at ucw dot cz>, gcc-patches at gcc dot gnu dot org
- Date: Mon, 13 Jun 2016 10:46:57 +0200
- Subject: Re: [BUILDROBOT] MPS430 build problem due to new enum (was: [PATCH 2/2] Add edge predictions pruning)
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1464868111 dot git dot mliska at suse dot cz> <538d1a7d03b247eb05e2fb15761298a7082bd9c3 dot 1464868111 dot git dot mliska at suse dot cz> <18442ad9-fb3b-8828-d99e-a38feb4f2753 at suse dot cz> <20160608124133 dot GB14058 at kam dot mff dot cuni dot cz> <94e15a58-4e9e-0957-111f-e80d57988717 at suse dot cz> <20160612115530 dot GD4454 at lug-owl dot de>
> Hi Martin,
>
> On Thu, 2016-06-09 13:24:10 +0200, Martin LiÅka <mliska@suse.cz> wrote:
> > On 06/08/2016 02:41 PM, Jan Hubicka wrote:
> > > Adding hash for this prupose is bit of an overkill (there are
> > > definitly cheaper ways of solving so), but it will hardly affect compile
> > > time, so the pathc is OK.
> >
> > Sending the final version where I added comments and I also changed
> > dump scanning to cover the new dump format.
>
> I just noticed a build problem my Build Robot found
> (http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=569576):
>
> g++ -fno-PIE -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -I. -I. -I/scratch/4/jbglaw/regular/repos/gcc/gcc -I/scratch/4/jbglaw/regular/repos/gcc/gcc/. -I/scratch/4/jbglaw/regular/repos/gcc/gcc/../include -I/scratch/4/jbglaw/regular/repos/gcc/gcc/../libcpp/include -I/scratch/4/jbglaw/regular/repos/gcc/gcc/../libdecnumber -I/scratch/4/jbglaw/regular/repos/gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I/scratch/4/jbglaw/regular/repos/gcc/gcc/../libbacktrace -o predict.o -MT predict.o -MMD -MP -MF ./.deps/predict.TPo /scratch/4/jbglaw/regular/repos/gcc/gcc/predict.c
> /scratch/4/jbglaw/regular/repos/gcc/gcc/predict.c:62:3: error: redeclaration of âNONEâ
> NONE,
Hmm, namespace conflict. I guess renaming enum items to REASON_* should solve it easily.
Or we can add a namespace.
Martin, both variants of fix are pre-approved.
Honza