This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Do not instrument string cst w/ unknown decl size (PR, sanitizer/71378)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Martin LiÅka <mliska at suse dot cz>, Jason Merrill <jason at redhat dot com>, Martin Sebor <msebor at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, polacek at redhat dot com
- Date: Fri, 3 Jun 2016 13:00:16 +0200
- Subject: Re: [PATCH] Do not instrument string cst w/ unknown decl size (PR, sanitizer/71378)
- Authentication-results: sourceware.org; auth=none
- References: <8263779f-b542-0440-92be-133a87e12345 at suse dot cz>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Jun 03, 2016 at 12:53:06PM +0200, Martin LiÅka wrote:
> As seen in the issue, we try to instrument a global variable that contains a string
> constant. Following patch does not instrument in the size is variable (VLA).
>
> Patch survives regression tests and bootstraps on x86_64-linux.
> It's questionable whether the same situation can also happen in asan_finish_file:
>
> FOR_EACH_DEFINED_VARIABLE (vnode)
> if (TREE_ASM_WRITTEN (vnode->decl)
> && asan_protect_global (vnode->decl))
> asan_add_global (vnode->decl, TREE_TYPE (type), v);
I think the STRING_CST with non-constant size is already a bug, so this
patch looks to me just like a workaround for a bug that is somewhere else.
We should either reject such bogosity already in the FE (e.g. C does not
allow this), or if we really want to support it, it should be genericized
differently (the string must have a fixed size, and either we allow in the
IL assignment of the fixed size array to the VLA, or it should be
genericized e.g. as memcpy from the fixed size STRING_CST to the start of
the VLA.
Jakub