This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[SH][committed] Simplify DImode add, sub, neg patterns
- From: Oleg Endo <oleg dot endo at t-online dot de>
- To: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 01 Jun 2016 00:32:27 +0900
- Subject: [SH][committed] Simplify DImode add, sub, neg patterns
- Authentication-results: sourceware.org; auth=none
Hi,
The attached patch simplifies some DImode patterns on SH. The
force_reg in the expand patterns can also be expressed by using the
appropriate predicate, which eliminates the need for the expand
patterns altogether.
Tested on sh-elf with
make -k check RUNTESTFLAGS="--target_board=sh-sim\{-m2/-ml,-m2/-mb,
-m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-mb}"
Committed as r236927.
Cheers,
Oleg
gcc/ChangeLog:
* config/sh/sh.md (adddi3, subdi3, negdi2, abs<mode>2): Remove
define_expand patterns.
(adddi3_compact): Rename to adddi3.
(subdi3_compact): Rename to subdi3.
(*negdi2): Rename to negdi2.
(*abs<mode>2): Rename to abs<mode>2.diff --git a/gcc/config/sh/sh.md b/gcc/config/sh/sh.md
index 406721d..30948ca 100644
--- a/gcc/config/sh/sh.md
+++ b/gcc/config/sh/sh.md
@@ -1535,18 +1535,7 @@
;; Addition instructions
;; -------------------------------------------------------------------------
-(define_expand "adddi3"
- [(set (match_operand:DI 0 "arith_reg_operand")
- (plus:DI (match_operand:DI 1 "arith_reg_operand")
- (match_operand:DI 2 "arith_operand")))]
- ""
-{
- operands[2] = force_reg (DImode, operands[2]);
- emit_insn (gen_adddi3_compact (operands[0], operands[1], operands[2]));
- DONE;
-})
-
-(define_insn_and_split "adddi3_compact"
+(define_insn_and_split "adddi3"
[(set (match_operand:DI 0 "arith_reg_dest")
(plus:DI (match_operand:DI 1 "arith_reg_operand")
(match_operand:DI 2 "arith_reg_operand")))
@@ -1938,21 +1927,10 @@
;; Subtraction instructions
;; -------------------------------------------------------------------------
-(define_expand "subdi3"
- [(set (match_operand:DI 0 "arith_reg_operand" "")
- (minus:DI (match_operand:DI 1 "arith_reg_or_0_operand" "")
- (match_operand:DI 2 "arith_reg_operand" "")))]
- ""
-{
- operands[1] = force_reg (DImode, operands[1]);
- emit_insn (gen_subdi3_compact (operands[0], operands[1], operands[2]));
- DONE;
-})
-
-(define_insn_and_split "subdi3_compact"
+(define_insn_and_split "subdi3"
[(set (match_operand:DI 0 "arith_reg_dest")
(minus:DI (match_operand:DI 1 "arith_reg_operand")
- (match_operand:DI 2 "arith_reg_operand")))
+ (match_operand:DI 2 "arith_reg_operand")))
(clobber (reg:SI T_REG))]
"TARGET_SH1"
"#"
@@ -4393,13 +4371,7 @@
;; Don't split into individual negc insns immediately so that neg:DI (abs:DI)
;; can be combined.
-(define_expand "negdi2"
- [(parallel [(set (match_operand:DI 0 "arith_reg_dest")
- (neg:DI (match_operand:DI 1 "arith_reg_operand")))
- (clobber (reg:SI T_REG))])]
- "TARGET_SH1")
-
-(define_insn_and_split "*negdi2"
+(define_insn_and_split "negdi2"
[(set (match_operand:DI 0 "arith_reg_dest")
(neg:DI (match_operand:DI 1 "arith_reg_operand")))
(clobber (reg:SI T_REG))]
@@ -4480,13 +4452,7 @@
}
[(set_attr "type" "arith")])
-(define_expand "abs<mode>2"
- [(parallel [(set (match_operand:SIDI 0 "arith_reg_dest")
- (abs:SIDI (match_operand:SIDI 1 "arith_reg_operand")))
- (clobber (reg:SI T_REG))])]
- "TARGET_SH1")
-
-(define_insn_and_split "*abs<mode>2"
+(define_insn_and_split "abs<mode>2"
[(set (match_operand:SIDI 0 "arith_reg_dest")
(abs:SIDI (match_operand:SIDI 1 "arith_reg_operand")))
(clobber (reg:SI T_REG))]