This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][RFC] Introduce BIT_FIELD_INSERT
- From: Richard Biener <rguenther at suse dot de>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Eric Botcazou <ebotcazou at adacore dot com>, gcc-patches at gcc dot gnu dot org, Michael Matz <matz at suse dot de>
- Date: Fri, 20 May 2016 13:41:01 +0200 (CEST)
- Subject: Re: [PATCH][RFC] Introduce BIT_FIELD_INSERT
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot LSU dot 2 dot 11 dot 1605131239490 dot 18037 at t29 dot fhfr dot qr> <alpine dot LSU dot 2 dot 20 dot 1605171718400 dot 13156 at wotan dot suse dot de> <alpine dot LSU dot 2 dot 11 dot 1605191521480 dot 18037 at t29 dot fhfr dot qr> <10155617 dot 0hHYLBiUYX at polaris> <alpine dot LSU dot 2 dot 11 dot 1605201057290 dot 18037 at t29 dot fhfr dot qr> <20160520112525 dot GH28550 at tucnak dot redhat dot com>
On Fri, 20 May 2016, Jakub Jelinek wrote:
> On Fri, May 20, 2016 at 10:59:18AM +0200, Richard Biener wrote:
> > Sounds good. I will commit later with your wording.
>
> Unfortunately, the new testcase fails e.g. on i?86-*-* or on powerpc*.
> On i?86-*-* (without -msse) I actually see 2 different issues, one is
> extra -Wpsabi warnings, and another is the dump scan, the optimization isn't
> used there at all if we don't have SSE HW.
> Surprisingly, on powerpc* the only problem is the extra warnings about ABI
> compatibility, but the scan matches, even if there is no vector support.
> Similarly on s390* too (and there are no warnings even).
I suppose they still have vector modes enabled.
> So, dunno if we should limit the scan-tree-dump-times only to a few selected
> arches (e.g. those where we add dg-additional-options for, plus some where
> it is known to work without additional options, like perhaps aarch64*-*-*,
> maybe spu*-*-*, what else?).
I'd say ppc and aarch64 are fine. Thanks for noticing.
Richard.
> 2016-05-20 Jakub Jelinek <jakub@redhat.com>
>
> PR tree-optimization/29756
> gcc.dg/tree-ssa/vector-6.c: Add -Wno-psabi -w to dg-options.
> Add -msse2 for x86 and -maltivec for powerpc.
>
> --- gcc/testsuite/gcc.dg/tree-ssa/vector-6.c.jj 2016-05-20 12:44:33.000000000 +0200
> +++ gcc/testsuite/gcc.dg/tree-ssa/vector-6.c 2016-05-20 13:17:08.730168547 +0200
> @@ -1,5 +1,7 @@
> /* { dg-do compile } */
> -/* { dg-options "-O -fdump-tree-ccp1" } */
> +/* { dg-options "-O -fdump-tree-ccp1 -Wno-psabi -w" } */
> +/* { dg-additional-options "-msse2" { target i?86-*-* x86_64-*-* } } */
> +/* { dg-additional-options "-maltivec" { target powerpc_altivec_ok } } */
>
> typedef int v4si __attribute__((vector_size (4 * sizeof (int))));
>
>
>
> Jakub