This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][AArch64] Simplify ashl<mode>3 expander for SHORT modes

From: Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>
To: GCC Patches <gcc-patches at gcc dot gnu dot org>
Cc: Marcus Shawcroft <marcus dot shawcroft at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, James Greenhalgh <james dot greenhalgh at arm dot com>
Date: Thu, 19 May 2016 14:26:08 +0100
Subject: Re: [PATCH][AArch64] Simplify ashl<mode>3 expander for SHORT modes
Authentication-results: sourceware.org; auth=none
References: <5720C867 dot 3060708 at foss dot arm dot com> <5732F4D5 dot 1040100 at foss dot arm dot com>

Ping.

Thanks,
Kyrill

On 11/05/16 10:01, Kyrill Tkachov wrote:

Ping.
https://gcc.gnu.org/ml/gcc-patches/2016-04/msg01651.html

Thanks,
Kyrill

On 27/04/16 15:10, Kyrill Tkachov wrote:

Hi all,

The ashl<mode>3 expander for QI and HI modes is needlessly obfuscated.
The 2nd operand predicate accepts nonmemory_operand but the expand code
FAILs if it's not a CONST_INT. We can just demand a const_int_operand in
the predicate and remove the extra CONST_INT check.

Looking at git blame, it seems it was written that way as a result of some
other refactoring a few years back for an unrelated change.

Bootstrapped and tested on aarch64-none-linux-gnu.
Ok for trunk?

Thanks,
Kyrill

2016-04-27  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

    * config/aarch64/aarch64.md (ashl<mode>3, SHORT modes):
    Use const_int_operand for operand 2 predicate.  Simplify expand code
    as a result.

References:
- Re: [PATCH][AArch64] Simplify ashl<mode>3 expander for SHORT modes
  - From: Kyrill Tkachov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]