This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/4] BRIG (HSAIL) frontend: The FE itself.
- From: David Malcolm <dmalcolm at redhat dot com>
- To: Pekka Jääskeläinen <pekka at parmance dot com>, Joseph Myers <joseph at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 18 May 2016 14:36:10 -0400
- Subject: Re: [PATCH 2/4] BRIG (HSAIL) frontend: The FE itself.
- Authentication-results: sourceware.org; auth=none
- References: <573A02A5 dot 1020003 at parmance dot com> <alpine dot DEB dot 2 dot 20 dot 1605180017140 dot 6325 at digraph dot polyomino dot org dot uk> <CAJk11WAS_heoFMe+uC0M+BfZX9Qyh5mY84+B8epd-z2UF5ez0Q at mail dot gmail dot com>
On Wed, 2016-05-18 at 19:59 +0300, Pekka JÃÃskelÃinen wrote:
> Hi Joseph,
>
> Thanks for the comments. Updated&rebased patch attached. Hopefully I
> didn't miss any diags.
It looks like the attachment doesn't contain the patch; on unzipping I
just see a 27 byte file reading "The BRIG frontend itself."
A similar problem seems to have happened with the update to 1/4:
https://gcc.gnu.org/ml/gcc-patches/2016-05/msg01385.html
where the "patch" just has the descriptive text, but not the actual
changes.
Looks like you need to resend both.
Hope this is helpful; good luck
Dave
> On Wed, May 18, 2016 at 3:20 AM, Joseph Myers <
> joseph@codesourcery.com> wrote:
> > This patch has many improperly formatted diagnostic messages (e.g.
> > starting with capital letters, ending with '.' or failing to use %q
> > for
> > quoting). I also note cases where you use %lu as a format for
> > size_t,
> > which is not correct (you'd need to add pretty-print.c support for
> > %zu
> > before you could use that, however).
> >
> > --
> > Joseph S. Myers
> > joseph@codesourcery.com