This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, libgomp] Rewire OpenACC async
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Thomas Schwinge <thomas_schwinge at mentor dot com>
- Cc: Chung-Lin Tang <cltang at codesourcery dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Cesar Philippidis <cesar_philippidis at mentor dot com>, Julian Brown <julian at codesourcery dot com>
- Date: Thu, 12 May 2016 12:56:37 +0200
- Subject: Re: [PATCH, libgomp] Rewire OpenACC async
- Authentication-results: sourceware.org; auth=none
- References: <56543B8C dot 404 at codesourcery dot com> <567910D1 dot 1060306 at codesourcery dot com> <56FA4F69 dot 1060101 at codesourcery dot com> <20160512100258 dot GV28550 at tucnak dot redhat dot com> <87y47fv9hl dot fsf at hertz dot schwinge dot homeip dot net>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, May 12, 2016 at 12:47:18PM +0200, Thomas Schwinge wrote:
> Hi!
>
> On Thu, 12 May 2016 12:02:58 +0200, Jakub Jelinek <jakub@redhat.com> wrote:
> > ABI incompatible change for the plugin
> > interface (affecting OpenACC capable plugins only), I think you just should
> > rename the plugin callback you add the argument to, so that
> > || !DLSYM_OPT (openacc.register_async_cleanup,
> > openacc_register_async_cleanup)
> > would fail when trying to load GCC 6.x nvptx plugin from GCC 7.x libgomp
> > or vice versa.
>
> Hmm, as far as I remember, we had previously agreed that libgomp plugin
> ABI changes are not of any concern, given that libgomp and its plugins
> will always be built from the same sources, at the same time, and so
> their ABIs will always correspond? Discussed before in
> <http://news.gmane.org/find-root.php?message_id=%3C56449E23.3050400%40acm.org%3E>,
> for example.
I thought the agreement was that it is ok not to support mixing of
different libgomp and plugin versions, but we should make sure that we
refuse to load the plugin in case of mismatch, instead of silently crashing.
Of course, changes in unreleased compiler versions are fine.
So, I'm not asking for compatibility in that 6.x nvptx plugin should still
work with 7.x libgomp and vice versa, but that it would be ignored or
diagnosed if somebody mixes it.
Jakub