Re: [PATCH] Apply fix for PR68463 to RS6000

[Thomas Schwinge <thomas at codesourcery dot com>]

Hi!

On Tue, 10 May 2016 10:39:33 -0500, James Norris <jnorris@codesourcery.com> wrote:
> The fix for PR68463 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68463)
> was missing code that prevented the fix from working on RS6000. The
> attached patch adds the missing code for RS6000.

:-( Bah.  When reviewing these changes,
<http://news.gmane.org/find-root.php?message_id=%3C8760xg7p8c.fsf%40hertz.schwinge.homeip.net%3E>,
I had been under the impression that all GNU/Linux targets use the
gcc/config/gnu-user.h file being patched there, hence my comment "I guess
we currently don't have to care about offloading configurations not using
the gnu-user.h file in which you modified the
STARTFILE_SPEC/ENDFILE_SPEC?" -- but as we now found out that hard way,
this PowerPC target does not actually, and so we need to repeat the
changes here:

>          * config/rs6000/sysv4.h (CRTOFFLOADBEGIN): Define. Add crtoffloadbegin.o
>          if offloading is enabled and -fopenacc or -fopenmp is specified.
>          (CRTOFFLOADEND): Likewise.
>          (STARTFILE_LINUX_SPEC): Add CRTOFFLOADBEGIN.
>          (ENDFILE_LINUX_SPEC): Add CRTOFFLOADEND.

Should have added a "PR driver/68463" tag to the ChangeLog snippet, to
get this commit added to <https://gcc.gnu.org/PR68463>.

Are you also going to commit this to gcc-6-branch, where it is broken in
the very same way?  You can do so "as obvious", without special approval.


GrÃÃe
 Thomas

Attachment: signature.asc
Description: PGP signature