This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Allow redefinition of libcilkrts debug macros
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Ilya Verbin <iverbin at gmail dot com>
- Cc: Jeff Law <law at redhat dot com>, gcc-patches at gcc dot gnu dot org, Ilya Verbin <ilya dot verbin at intel dot com>, "Balaji V. Iyer" <balaji dot v dot iyer at intel dot com>
- Date: Fri, 29 Apr 2016 14:07:50 +0200
- Subject: Re: Allow redefinition of libcilkrts debug macros
- Authentication-results: sourceware.org; auth=none
- References: <yddlh40a2kt dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE> <bad54655-5c0b-e6f2-88b8-6929665989d8 at redhat dot com> <yddoa8sx03y dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE> <20160429114611 dot GB27336 at msticlxl57 dot ims dot intel dot com>
Hi Ilya,
>> >> 2016-04-07 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
>> >>
>> >> * runtime/except-gcc.cpp (DEBUG_EXCEPTIONS): Allow redefinition.
>> >> * runtime/cilk_fiber.h (FIBER_DEBUG): Likewise.
>> >> * runtime/scheduler.h (REDPAR_DEBUG): Likewise.
>> > Ilya will have to chime in here -- we're a downstream consumer of the Cilk+
>> > runtime. So these patches need to go into Intel's tree first, then Ilya
>> > can bring them into the GCC tree.
>>
>> I suspected that much. It would be good to have a libcilkrts/README.gcc
>> describing the rules which changes can go into the gcc tree directly,
>> which need to go upstream first, and how. libo and libsanitizer already
>> have this.
>
> Could you please submit your patch to
> <www.cilkplus.org/submit-cilk-contribution>?
> All patches for libcilkrts/* should go there first in order to avoid possible
> license issues, or possible losses during the merge.
sure, will do. So current upstream libcilkrts should easily
interoperate with current gcc trunk? That way, I'll be able to complete
the SPARC port from PR target/68945 upstream and just wait for the next
merge to drag it in.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University