This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][AArch64] Work around PR target/64971

From: Jeff Law <law at redhat dot com>
To: Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Cc: James Greenhalgh <james dot greenhalgh at arm dot com>, Marcus Shawcroft <marcus dot shawcroft at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Andrew Pinski <apinski at cavium dot com>, "rth at redhat dot com" <rth at redhat dot com>
Date: Fri, 15 Apr 2016 10:15:38 -0600
Subject: Re: [PATCH][AArch64] Work around PR target/64971
Authentication-results: sourceware.org; auth=none
References: <5710F670 dot 3010605 at foss dot arm dot com>

On 04/15/2016 08:10 AM, Kyrill Tkachov wrote:

Hi all,

This is a repost of Andrew's fix for PR target/64971 that was originally
posted at:
https://gcc.gnu.org/ml/gcc-patches/2015-02/msg00502.html

The only change is that I substituted DImode for Pmode and added a FIXME
comment
to remind us to revisit this (see the PR in bugzilla for more info).

Bootstrapped and tested on aarch64-none-linux-gnu (LP64, I don't have
access to a full ILP32 system)
This patch affects only ILP32 codegen so I've run a make check on
aarch64-none-elf with /-mabi=ilp32 and nothing regressed.
I think at this stage it's the least risky band-aid.

Is this ok for trunk at this stage?

Thanks,
Kyrill

2016-04-15  Andrew Pinski  <apinski@cavium.com>
             Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

     PR target/65971
     * config/aarch64/aarch64.md (sibcall): Force call
     address to be DImode for ILP32.
     (sibcall_value): Likewise.

2016-04-15  Andrew Pinski  <apinski@cavium.com>

     * gcc.c-torture/compile/pr37433-1.c: New testcase.

Just a note, gcc-6 has branched, so you'll need to apply to the trunkand the branch once approved.

I would suggest that the issues raised by Richard be addressedseparately, possibly using a new BZ for tracking purposes.


Jeff

References:
- [PATCH][AArch64] Work around PR target/64971
  - From: Kyrill Tkachov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]