This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH to disable the canonical types check in verify_type (PR c++/70029)
- From: Marek Polacek <polacek at redhat dot com>
- To: Jason Merrill <jason at redhat dot com>
- Cc: Jakub Jelinek <jakub at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <hubicka at ucw dot cz>
- Date: Thu, 14 Apr 2016 18:12:07 +0200
- Subject: Re: PATCH to disable the canonical types check in verify_type (PR c++/70029)
- Authentication-results: sourceware.org; auth=none
- References: <20160414143058 dot GA28445 at redhat dot com> <570FB0AE dot 9060002 at redhat dot com> <20160414150519 dot GE19207 at tucnak dot redhat dot com> <570FB4E3 dot 3040409 at redhat dot com>
On Thu, Apr 14, 2016 at 11:18:59AM -0400, Jason Merrill wrote:
> On 04/14/2016 11:05 AM, Jakub Jelinek wrote:
> >On Thu, Apr 14, 2016 at 11:01:02AM -0400, Jason Merrill wrote:
> >>On 04/14/2016 10:30 AM, Marek Polacek wrote:
> >>>+ /* FIXME: this is violated by the C++ FE as discussed in PR70029, when
> >>>+ FUNCTION_*_QUALIFIED flags are set. */
> >>>+ if (0 && TYPE_MAIN_VARIANT (t) == t && ct && TYPE_MAIN_VARIANT (ct) != ct)
> >>
> >>How about guarding this check with flag_checking rather than disabling it
> >>entirely? That way it won't affect released compilers, and we can downgrade
> >>the PR from P1, but doesn't hide the bug.
> >
> >That will still mean people who use -fchecking will keep reporting such
> >ICEs. I think it is better to disable it and reenable after GCC 6 branches.
>
> OK.
Should I consider the patch approved or do we want to hear from Honza?
Marek