This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH to disable the canonical types check in verify_type (PR c++/70029)

From: Jason Merrill <jason at redhat dot com>
To: Marek Polacek <polacek at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <hubicka at ucw dot cz>
Date: Thu, 14 Apr 2016 11:01:02 -0400
Subject: Re: PATCH to disable the canonical types check in verify_type (PR c++/70029)
Authentication-results: sourceware.org; auth=none
References: <20160414143058 dot GA28445 at redhat dot com>

On 04/14/2016 10:30 AM, Marek Polacek wrote:

+  /* FIXME: this is violated by the C++ FE as discussed in PR70029, when
+     FUNCTION_*_QUALIFIED flags are set.  */
+  if (0 && TYPE_MAIN_VARIANT (t) == t && ct && TYPE_MAIN_VARIANT (ct) != ct)

How about guarding this check with flag_checking rather than disablingit entirely? That way it won't affect released compilers, and we candowngrade the PR from P1, but doesn't hide the bug.


Jason

Follow-Ups:
- Re: PATCH to disable the canonical types check in verify_type (PR c++/70029)
  - From: Jakub Jelinek

References:
- PATCH to disable the canonical types check in verify_type (PR c++/70029)
  - From: Marek Polacek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]