This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][Testsuite] Add --param sra-max-scalarization-size-Ospeed to sra-12.c
- From: "Andre Vieira (lists)" <Andre dot SimoesDiasVieira at arm dot com>
- To: gcc-patches at gcc dot gnu dot org
- Cc: law at redhat dot com
- Date: Mon, 4 Apr 2016 13:29:36 +0100
- Subject: Re: [PATCH][Testsuite] Add --param sra-max-scalarization-size-Ospeed to sra-12.c
- Authentication-results: sourceware.org; auth=none
- References: <1445442727-9557-1-git-send-email-alan dot lawrence at arm dot com> <5627B673 dot 30502 at redhat dot com> <56EBD9CC dot 2010103 at arm dot com>
On 18/03/16 10:34, Andre Vieira (lists) wrote:
> On 21/10/15 16:59, Jeff Law wrote:
>> On 10/21/2015 09:52 AM, Alan Lawrence wrote:
>>> gcc.dg/tree-ssa/sra-12.c is skipped on a bunch of targets, including
>>> AArch64,
>>> because the default max-scalarization-size depends on MOVE_RATIO, and
>>> on those
>>> targets thus ends up being too small for SRA to optimize the testcase.
>>> Recently
>>> I noticed that the test has been failing for some time on ARM too.
>>> This patch
>>> fixes the test on ARM, AArch64, avr, and sh, and by extension I
>>> believe also on
>>> nds32, although I haven't managed to build a nds32 compiler to check.
>>>
>>> There is an argument that instead we should skip the test on ARM too;
>>> or rather,
>>> since at least ARM and AArch64 would like the test to pass, we should
>>> xfail it
>>> on those platforms until we have time to experiment with the
>>> threshold/param for
>>> SRA. I hope to do some more investigation on that front as part of (or
>>> followup
>>> to) PR/63679.
>>>
>>> Is this OK for trunk?
>>>
>>> Cheers,
>>> Alan
>>>
>>> gcc/testsuite/ChangeLog:
>>>
>>> * gcc.dg/tree-ssa/sra-12.c: Enable test on all targets; add --param
>>> sra-max-scalarization-size-Ospeed.
>> OK.
>> jeff
>>
>
> OK to backport this to gcc-5-branch?
>
> Cheers,
> Andre
>
Ping.