This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, PR70161] Fix fdump-ipa-all-graph
- From: Richard Biener <rguenther at suse dot de>
- To: Tom de Vries <Tom_deVries at mentor dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <hubicka at ucw dot cz>
- Date: Tue, 15 Mar 2016 12:37:16 +0100 (CET)
- Subject: Re: [PATCH, PR70161] Fix fdump-ipa-all-graph
- Authentication-results: sourceware.org; auth=none
- References: <56E6D97F dot 3030606 at mentor dot com>
On Mon, 14 Mar 2016, Tom de Vries wrote:
> Hi,
>
> this patch fixes PR70161, a 4.9/5/6 regression.
>
> Currently when using -fdump-ipa-all-graph, the compiler ICEs in
> execute_function_dump when testing for pass->graph_dump_initialized, because
> pass == NULL.
>
> The patch fixes:
> - the ICE by setting the pass argument in the call to
> execute_function_dump in execute_one_ipa_transform_pass
> - a subsequent ICE (triggered with -fipa-pta) by saving, resetting and
> restoring dump_file_name in cgraph_node::get_body, alongside the
> saving and restoring of the dump_file variable.
> - the duplicate edges in the subsequently generated dot file by
> ensuring that execute_function_dump is called only once per function
> per pass. [ Note that this bit also has an effect for the normal dump
> files for the ipa passes with transform function. For those functions,
> atm execute_function_dump is called both after execute and after
> transform. With the patch, it's only called after transform. ]
>
> Bootstrapped and reg-tested on x86_64.
>
> OK for stage4?
Ok.
Thanks,
Richard.