This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/2][GCC][ARM] Fix testcases after introduction of Cortex-R8
- From: Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>
- To: "Andre Vieira (lists)" <Andre dot SimoesDiasVieira at arm dot com>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 08 Mar 2016 14:56:55 +0000
- Subject: Re: [PATCH 2/2][GCC][ARM] Fix testcases after introduction of Cortex-R8
- Authentication-results: sourceware.org; auth=none
- References: <56D6DA1E dot 3020508 at arm dot com> <56D6DADF dot 9020103 at arm dot com> <56D81FE8 dot 7070904 at foss dot arm dot com> <56DEB204 dot 1030403 at arm dot com>
Hi Andre,
On 08/03/16 11:05, Andre Vieira (lists) wrote:
On 03/03/16 11:28, Kyrill Tkachov wrote:
Hi Andre,
On 02/03/16 12:21, Andre Vieira (lists) wrote:
Hi,
Tests used to check for "r8" which will not work because cortex-r8
string is now included in the assembly. Fixed by checking for "[^\-]r8".
Is this Ok?
Cheers,
Andre
gcc/testsuite/ChangeLog:
2016-03-02 Andre Vieira <andre.simoesdiasvieira@arm.com>
* gcc.target/arm/pr45701-1.c: Change assembler scan to not
trigger for cortex-r8, when scanning for register r8.
* gcc.target/arm/pr45701-2.c: Likewise.
Ok.
Thanks,
Kyrill
Thomas commited on my behalf at revision r234040.
Had to rebase arm-tune.md and invoke.texi, these were all obvious changes.
I'm seeing a DejaGNU error while testing RUNTESTFLAGS="arm.exp=pr45701-*.c":
ERROR: (DejaGnu) proc "^-" does not exist.
The error code is NONE
The info on the error is:
invalid command name "^-"
while executing
"::tcl_unknown ^-"
("uplevel" body line 1)
invoked from within
"uplevel 1 ::tcl_unknown $args"
That's due to the scan-assembler-not test:
/* { dg-final { scan-assembler-not "[^\-]r8" } } */
The '[' and ']' need to be escaped by a backslash.
Can you please post a patch to add the escapes.
Sorry for missing this in the original review...
Kyrill
Cheers,
Andre