Re: [committed] Fix libffi/70024

[Richard Henderson <rth at redhat dot com>]

On 03/03/2016 05:35 AM, Rainer Orth wrote:
> Hi Richard,
>
> > Unfortunately, even with this fixed, all Solaris/x86 tests now fail to
> > link:
> >
> > FAIL: libffi.call/closure_fn0.c -W -Wall -Wno-psabi -O0 (test for excess errors)
> > Excess errors:
> > Undefined                       first referenced
> >   symbol                             in file
> > ffi_closure_alloc                   /var/tmp//ccIpq3qc.o
> > ffi_type_float                      /var/tmp//ccIpq3qc.o
> > ffi_type_uint64                     /var/tmp//ccIpq3qc.o
> > ffi_type_sint32                     /var/tmp//ccIpq3qc.o
> > ffi_type_sint16                     /var/tmp//ccIpq3qc.o
> > ffi_type_double                     /var/tmp//ccIpq3qc.o
> > ffi_prep_cif                        /var/tmp//ccIpq3qc.o
> > ld: fatal: symbol referencing errors
>
> turned out to be easy, too: make_sunver.pl got passed a list of
> non-existant object files:
>
> .libs/src/prep_cif.o .libs/src/types.o .libs/src/raw_api.o .libs/src/java_raw_api.o .libs/src/closures.o
>
> Treating $(libffi_la_OBJECTS) and $(libffi_la_LIBADD) the same fixed
> this so all the symbols above got included in libffi.map-sun and all
> tests pass.
>
> Tested on i386-pc-solaris2.12, installed on mainline.

Thanks.


r~