This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 1/9] gensupport: Fix define_subst operand renumbering.
- From: Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>
- To: Bernd Schmidt <bschmidt at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Cc: uweigand at de dot ibm dot com
- Date: Tue, 1 Mar 2016 10:29:28 +0100
- Subject: Re: [PATCH 1/9] gensupport: Fix define_subst operand renumbering.
- Authentication-results: sourceware.org; auth=none
- References: <1456735599-21355-1-git-send-email-krebbel at linux dot vnet dot ibm dot com> <1456735599-21355-2-git-send-email-krebbel at linux dot vnet dot ibm dot com> <56D4497A dot 40304 at redhat dot com>
On 02/29/2016 02:36 PM, Bernd Schmidt wrote:
> On 02/29/2016 09:46 AM, Andreas Krebbel wrote:
>> Ok for mainline?
>>
>> * gensupport.c (process_substs_on_one_elem): Split loop to
>> complete mark_operands_used_in_match_dup on all expressions in the
>> vector first.
>> (adjust_operands_numbers): Inline into process_substs_on_one_elem
>> and remove function.
>
> Didn't I approve this a while ago? Not sure it's appropriate for stage4
> though; is this series fixing an important regression?
Yes you did. I didn't commit it until the rest of the patch series was ready to commit. The patch
series fixes a fundamental problem in the backend. The first iteration was posted before stage 4 but
it took me a few iterations to get it right.
I've committed the patch now after retesting.
-Andreas-