This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [hsa, testsuite] Suppress hsa warnings in libgomp tests
- From: Jakub Jelinek <jakub at redhat dot com>
- To: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 26 Feb 2016 17:07:56 +0100
- Subject: Re: [hsa, testsuite] Suppress hsa warnings in libgomp tests
- Authentication-results: sourceware.org; auth=none
- References: <20160226155957 dot GJ3094 at virgil dot suse dot cz>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Feb 26, 2016 at 04:59:57PM +0100, Martin Jambor wrote:
> just like with the compiler gomp testsuite, we need to add -Wno-hsa to
> options when compiling libgomp testcases in order not to have "excess
> errors" failures when HSA is enabled. There are quite many of such
> testcases on the trunk because I have disabled the dynamic parallelism
> way of executing stuff. Hopefully we'll be able to revert many of the
> hunks below when we get that working.
>
> The patch has been tested both with and without HSA enabled. OK for
> trunk?
I don't like this very much.
Couldn't you instead add -Wno-hsa next to -fopenmp in *.exp, and just where
you want to explicitly check the hsa warnings, enable it manually in
dg-options or dg-additional-options (it would need to be guarded with hsa
being enabled etc. anyway).
Jakub