This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix DW_OP_GNU_implicit_pointer referring to DW_TAG_dwarf_procedure (PR debug/69947)
- From: Pierre-Marie de Rodat <derodat at adacore dot com>
- To: Jakub Jelinek <jakub at redhat dot com>, Jason Merrill <jason at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Cary Coutant <ccoutant at gmail dot com>, Eric Botcazou <ebotcazou at adacore dot com>
- Date: Fri, 26 Feb 2016 09:59:16 +0100
- Subject: Re: [PATCH] Fix DW_OP_GNU_implicit_pointer referring to DW_TAG_dwarf_procedure (PR debug/69947)
- Authentication-results: sourceware.org; auth=none
- References: <564CE0F7 dot 4060801 at redhat dot com> <56531A3E dot 40504 at adacore dot com> <56538037 dot 7060900 at redhat dot com> <56542B0F dot 6040102 at adacore dot com> <5655FF72 dot 7030901 at redhat dot com> <5656FC6C dot 7040008 at adacore dot com> <566B3151 dot 4000209 at redhat dot com> <56712691 dot 4050709 at adacore dot com> <20160225094803 dot GN3017 at tucnak dot redhat dot com> <56CF2396 dot 7000102 at adacore dot com> <20160225164640 dot GW3017 at tucnak dot redhat dot com>
On 02/25/2016 05:46 PM, Jakub Jelinek wrote:
Ah, I've been looking for something that would set die_perennial_p, but
actually you just set die_mark later on instead for those.
So IMHO the right fix is just handle all the ops that could directly or
indirectly contain references to other DIEs, rather than just handling
the 3 you have there.
Agreed! (as per the patch I sent)
Going to bootstrap/regtest this on x86_64-linux and i686-linux now.
Is this ok for trunk if it passes testing?
I guess this was not for me as Iâm not maintainer, but: this looks
completely fine to me. :-) Thanks!
--
Pierre-Marie de Rodat