This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Further -Wnonnull-compare fixes (PR c++/69922)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Jason Merrill <jason at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 24 Feb 2016 21:05:10 +0100
- Subject: Re: [PATCH] Further -Wnonnull-compare fixes (PR c++/69922)
- Authentication-results: sourceware.org; auth=none
- References: <20160224190503 dot GJ3017 at tucnak dot redhat dot com> <56CE0B3D dot 40509 at redhat dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Feb 24, 2016 at 02:57:49PM -0500, Jason Merrill wrote:
> On 02/24/2016 02:05 PM, Jakub Jelinek wrote:
> >+ && integer_zerop (tree_strip_nop_conversions (TREE_OPERAND (org_x,
> >+ 1))))
>
> Why check this? I think we want this handling for all TREE_NO_WARNING
> comparisons.
There probably aren't any other anyway, so it is really not needed.
Is the patch ok with those two lines removed and ) moved?
Jakub