This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][CilkPlus] Fix PR69363
- From: Ilya Verbin <iverbin at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Kirill Yukhin <kirill dot yukhin at gmail dot com>
- Date: Wed, 17 Feb 2016 18:08:14 +0300
- Subject: Re: [PATCH][CilkPlus] Fix PR69363
- Authentication-results: sourceware.org; auth=none
- References: <20160217143258 dot GA31394 at msticlxl57 dot ims dot intel dot com> <20160217144600 dot GG3017 at tucnak dot redhat dot com>
On Wed, Feb 17, 2016 at 15:46:00 +0100, Jakub Jelinek wrote:
> On Wed, Feb 17, 2016 at 05:32:58PM +0300, Ilya Verbin wrote:
> > + && !SCALAR_FLOAT_TYPE_P (TREE_TYPE (t))
> > + && TREE_CODE (TREE_TYPE (t)) != POINTER_TYPE)
> > + {
> > + error_at (OMP_CLAUSE_LOCATION (c),
> > + "linear clause applied to non-integral, "
> > + "non-floating, non-pointer variable with type %qT",
> > + TREE_TYPE (t));
> > + remove = true;
> > + break;
> > + }
> > + }
> > + else
> > + {
> > + if (!INTEGRAL_TYPE_P (TREE_TYPE (t))
> > + && TREE_CODE (TREE_TYPE (t)) != POINTER_TYPE)
> > + {
> > + error_at (OMP_CLAUSE_LOCATION (c),
> > + "linear clause applied to non-integral non-pointer "
>
> This line is too long. But you could have just done
My editor shows exactly 80 chars.
> > --- a/gcc/cp/semantics.c
> > +++ b/gcc/cp/semantics.c
>
> > + error ("linear clause applied to non-integral, "
> > + "non-floating, non-pointer variable with %qT type",
>
> Again too long line, that needs to be wrapped more.
OK, here is 81.
> > + TREE_TYPE (t));
> > + remove = true;
> > + break;
> > + }
> > + }
> > + else
> > + {
> > + if (!INTEGRAL_TYPE_P (type)
> > + && TREE_CODE (type) != POINTER_TYPE)
> > + {
> > + error ("linear clause applied to non-integral non-pointer "
> > + "variable with %qT type", TREE_TYPE (t));
> > + remove = true;
> > + break;
>
> And this can be done like I've hinted above.
OK, here is 81.
-- Ilya