This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, PR69607] Mark offload symbols as global in lto
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Tom de Vries <Tom_deVries at mentor dot com>, Jan Hubicka <hubicka at ucw dot cz>, Richard Biener <rguenther at suse dot de>
- Cc: "gcc-patches at gnu dot org" <gcc-patches at gnu dot org>, Ilya Verbin <iverbin at gmail dot com>
- Date: Wed, 17 Feb 2016 13:30:02 +0100
- Subject: Re: [PATCH, PR69607] Mark offload symbols as global in lto
- Authentication-results: sourceware.org; auth=none
- References: <56B89150 dot 7000209 at mentor dot com> <56C46149 dot 3060503 at mentor dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Feb 17, 2016 at 01:02:17PM +0100, Tom de Vries wrote:
> Mark offload symbols as global in lto
I'm really not familiar with that part of LTO, so I'm CCing Honza and
Richard here.
> 2016-02-08 Tom de Vries <tom@codesourcery.com>
>
> PR lto/69607
> * lto-partition.c (promote_offload_tables): New function.
> * lto-partition.h (promote_offload_tables): Declare.
Just one space instead of two after :
> * lto.c (do_whole_program_analysis): call promote_offload_tables.
Capital C in Call.
> --- /dev/null
> +++ b/libgomp/testsuite/libgomp.c/target-36.c
> @@ -0,0 +1,4 @@
> +/* { dg-do run { target lto } } */
> +/* { dg-additional-options "-flto -flto-partition=1to1 -fno-toplevel-reorder" } */
> +
> +#include "target-1.c"
> diff --git a/libgomp/testsuite/libgomp.c/target-37.c b/libgomp/testsuite/libgomp.c/target-37.c
> new file mode 100644
> index 0000000..1edb21e
> --- /dev/null
> +++ b/libgomp/testsuite/libgomp.c/target-37.c
> @@ -0,0 +1,98 @@
> +/* { dg-do run { target lto } } */
> +/* { dg-additional-sources "target-38.c" } */
> +/* { dg-additional-options "-flto -flto-partition=1to1 -fno-toplevel-reorder" } */
> +
> +extern
> +#ifdef __cplusplus
> +"C"
> +#endif
> +void abort (void);
Why the C++ stuff in there? Do you intend to include the testcase
also in libgomp.c++? If not, it is not needed.
Otherwise, the tests LGTM.
Jakub