This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR driver/69265: improved suggestions for various misspelled options
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Bernd Schmidt <bschmidt at redhat dot com>
- Cc: David Malcolm <dmalcolm at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 11 Feb 2016 10:16:02 +0100
- Subject: Re: [PATCH] PR driver/69265: improved suggestions for various misspelled options
- Authentication-results: sourceware.org; auth=none
- References: <1452721822-63163-1-git-send-email-dmalcolm at redhat dot com> <1455050696 dot 18873 dot 12 dot camel at redhat dot com> <56BB6485 dot 8080908 at redhat dot com>
On Wed, Feb 10, 2016 at 5:25 PM, Bernd Schmidt <bschmidt@redhat.com> wrote:
> On 02/09/2016 09:44 PM, David Malcolm wrote:
>>
>> This is a bug in a new feature, so it isn't a regression as such, but
>> it's fairly visible, and I believe the fix is relatively low-risk
>> (error-handling of typos of command-line options).
>>
>> This also now covers PR driver/69453 (and its duplicate PR
>> driver/69642), so people *are* running into this.
>
>
> I think the patch looks reasonable (I expect it needs slight adjustment
> after an earlier sanitizer options change). Whether it's OK or not at this
> stage is something I think I'll want to ask a RM. My inclination would be
> yes.
Yes.
Richard.
> A small improvement might be calculating the candidates array only once when
> making the first suggestion and not freeing it. BTW, I've also run into a
> case of an unhelpful suggestion:
>
> ./cc1 ~/hw.c -fno-if-convert
> cc1: error: unrecognized command line option â-fno-if-convertâ
>
> which should instead suggest fno-if-conversion.
>
>
> Bernd