This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, PR67709 ] Don't call call_cgraph_insertion_hooks in simd_clone_create
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Tom de Vries <Tom_deVries at mentor dot com>, Jan Hubicka <hubicka at ucw dot cz>, Richard Biener <rguenther at suse dot de>
- Cc: "gcc-patches at gnu dot org" <gcc-patches at gnu dot org>
- Date: Mon, 8 Feb 2016 13:54:56 +0100
- Subject: Re: [PATCH, PR67709 ] Don't call call_cgraph_insertion_hooks in simd_clone_create
- Authentication-results: sourceware.org; auth=none
- References: <56B88E34 dot 2050400 at mentor dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, Feb 08, 2016 at 01:46:44PM +0100, Tom de Vries wrote:
> [ The pass before pass_omp_simd_clone is pass_dispatcher_calls. It has a
> function create_target_clone, similar to simd_clone_create, with a
> node.defition and !node.defition part. The !node.defition part does not call
> 'symtab->call_cgraph_insertion_hooks (new_node)'. ]
I'll defer to Honza or Richi if it is ok not to call cgraph insertion hooks
at this point (and since when they can be avoided), or what else should be
done.
The patch could be ok even for 6.0, not just stage1, if they are ok with it
(or propose some other change).
> Don't call call_cgraph_insertion_hooks in simd_clone_create
>
> 2016-02-08 Tom de Vries <tom@codesourcery.com>
>
> PR lto/67709
> * omp-low.c (simd_clone_create): Remove call to
> symtab->call_cgraph_insertion_hooks.
>
> * testsuite/libgomp.fortran/declare-simd-4.f90: New test.
Jakub