This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Fix split-path-2.c on targets with unsigned characters by default



Andreas pointed out the test was failing on aarch64. It turns out it's got to be failing on all targets where characters are unsigned by default as the test assumes characters are signed by default. Opps.

The fix is pretty obvious.  Just make the array of chars be signed chars.

Installed after verifying x86-linux still passes and hand verification of aarch64 as well.

Sorry for the breakage.

jeff
commit b32ded8cd0158d88155116bde4685a36c4802878
Author: law <law@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Mon Feb 8 08:40:00 2016 +0000

            PR tree-optimization/68541
            * gcc.dg/tree-ssa/split-path-2.c: Make char array explicitly signed.
    
    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@233208 138bc75d-0d04-0410-961f-82ee72b054a4

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 6940136..6aa927d 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,5 +1,8 @@
 2016-02-08  Jeff Law  <law@redhat.com>
 
+	PR tree-optimization/68541
+	* gcc.dg/tree-ssa/split-path-2.c: Make char array explicitly signed.
+
         PR tree-optimization/65917
 	* gcc.dg/tree-ssa/20030922-2.c: No longer xfailed.
 
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/split-path-2.c b/gcc/testsuite/gcc.dg/tree-ssa/split-path-2.c
index aeb926e..8f503f2 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/split-path-2.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/split-path-2.c
@@ -2,7 +2,7 @@
 /* { dg-options "-O2 -fsplit-paths -fdump-tree-split-paths-details " } */
 
 int
-foo(char *p, int n)
+foo(signed char *p, int n)
 {
   int s = 0;
   int i;

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]