This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, fortran] PR69385 - [6 regression] ICE on valid with -fcheck=mem
- From: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- To: Janus Weil <janus at gcc dot gnu dot org>
- Cc: "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 26 Jan 2016 22:59:34 +0100
- Subject: Re: [Patch, fortran] PR69385 - [6 regression] ICE on valid with -fcheck=mem
- Authentication-results: sourceware.org; auth=none
- References: <CAGkQGi+zEnwmmGH2Uz5qcFMH+opN4MZbvSx3Fs+7sKHnnNaLZA at mail dot gmail dot com> <CAKwh3qiLqqENjGPGn4HGqt2zk3PFdrB7oLBRrrWmD__fSmMynQ at mail dot gmail dot com>
Dear Janus,
Thanks - committed as revision 232850.
I hope that this signals your return - we need your help!
Paul
On 25 January 2016 at 22:13, Janus Weil <janus@gcc.gnu.org> wrote:
> Hi Paul,
>
> seems we were pretty well-synchronized in posting this (in the PR it
> sounded as if you wanted me to submit it ...)
>
> In any case, the patch is ok for my taste.
>
> Thanks!
>
> Cheers,
> Janus
>
>
>
> 2016-01-25 22:02 GMT+01:00 Paul Richard Thomas <paul.richard.thomas@gmail.com>:
>> Dear All,
>>
>> The initial report concerns initialization assignments that should be
>> excluded from the check for assignment of scalars to unallocated
>> arrays. This part is so trivial that it does not require a test. On
>> the other hand, the block that implemented the check was plain and
>> simple wrong and the rest of the patch corrects this. It is commented
>> such as to be fully comprehensible.
>>
>> Bootstrapped and regtested on FC21/x86_64 - OK for trunk and for
>> 5-branch when all the wrinkles (PR69422 and 69423) are sorted out?
>>
>> Cheers
>>
>> Paul
>>
>> 2016-01-25 Paul Thomas <pault@gcc.gnu.org>
>>
>> PR fortran/69385
>> * trans-expr.c (gfc_trans_assignment_1): Exclude initialization
>> assignments from check on assignment of scalars to unassigned
>> arrays and correct wrong code within the corresponding block.
>>
>> 2015-01-25 Paul Thomas <pault@gcc.gnu.org>
>>
>> PR fortran/69385
>> * gfortran.dg/allocate_error_6.f90: New test.
--
The difference between genius and stupidity is; genius has its limits.
Albert Einstein