This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[PATCH] libitm: Disable testing transaction-safe exceptions on Darwin and AIX.
- From: Torvald Riegel <triegel at redhat dot com>
- To: Mike Stump <mikestump at comcast dot net>
- Cc: Dominique d'Humières <dominiq at lps dot ens dot fr>, Jonathan Wakely <jwakely at redhat dot com>, libstdc++ at gcc dot gnu dot org, gcc-patches <gcc-patches at gcc dot gnu dot org>, Jack Howarth <howarth at bromo dot med dot uc dot edu>
- Date: Thu, 21 Jan 2016 19:15:16 +0100
- Subject: [PATCH] libitm: Disable testing transaction-safe exceptions on Darwin and AIX.
- Authentication-results: sourceware.org; auth=none
- References: <1EF9008F-5418-4A35-AA1F-9931E464B0AA at lps dot ens dot fr> <1453230646 dot 23593 dot 13 dot camel at localhost dot localdomain> <20160119192001 dot GK15084 at redhat dot com> <572007D4-C174-4181-8CE9-88D930581163 at lps dot ens dot fr> <1453389937 dot 4592 dot 3 dot camel at localhost dot localdomain> <DC392244-3DBD-4DF1-AB7F-1689F6B30E9F at lps dot ens dot fr> <C0EE0B6E-72F4-4B44-8B0E-4BD424871A03 at lps dot ens dot fr> <6EEDF783-378A-4F21-89A5-6FD0914837F5 at comcast dot net>
On Thu, 2016-01-21 at 10:06 -0800, Mike Stump wrote:
> On Jan 21, 2016, at 9:29 AM, Dominique d'HumiÃres <dominiq@lps.ens.fr> wrote:
> > // { dg-do run { target { ! { *-*-darwin* powerpc-ibm-aix* } } } }
>
> A comment to hint that this has something to do with weak undefined would be nice.
Here's the patch I prepared (which indeed includes a comment).
OK for trunk? I'm not quite sure whether this qualifies as a
regression, but having an additional test that now fails is one I guess.
commit 0323fed14832e5744cbc63bcfeeb6728f7f13394
Author: Torvald Riegel <triegel@redhat.com>
Date: Thu Jan 21 16:21:33 2016 +0100
libitm: Disable testing transaction-safe exceptions on Darwin and AIX.
* testsuite/libitm.c++/libstdc++-safeexc.C: Not supported on darwin
or AIX.
diff --git a/libitm/testsuite/libitm.c++/libstdc++-safeexc.C b/libitm/testsuite/libitm.c++/libstdc++-safeexc.C
index 3e1655e..20e2e5e 100644
--- a/libitm/testsuite/libitm.c++/libstdc++-safeexc.C
+++ b/libitm/testsuite/libitm.c++/libstdc++-safeexc.C
@@ -2,7 +2,10 @@
// are indeed that. Thus, this also tests the transactional clones in
// libstdc++ and libsupc++.
-// { dg-do run }
+// Not supported on Darwin nor AIX because those lack the support for
+// weak references to undefined functions that we need in libstdc++ to make
+// exceptions transaction-safe.
+// { dg-do run { target { ! { *-*-darwin* powerpc-ibm-aix* } } } }
#include <iostream>
#include <exception>