This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/5] s390: Use proper read-only data section for literals.


On 20/01/16 14:11, Andreas Krebbel wrote:
On 01/02/2016 08:16 PM, Marcin KoÅcielnicki wrote:
Previously, .rodata was hardcoded.  For C++ vague linkage functions,
this resulted in needlessly duplicated literals.  With the new split
stack support, this resulted in link errors, due to .rodata containing
relocations to the discarded text sections.

gcc/ChangeLog:

	* config/s390/s390.md (pool_section_start): Use switch_to_section
	to select proper read-only data section instead of hardcoding .rodata.
	(pool_section_end): Use switch_to_section to match the above.
---
  gcc/ChangeLog           |  6 ++++++
  gcc/config/s390/s390.md | 11 +++++++++--
  2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 23ce209..2c572a7 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2016-01-02  Marcin KoÅcielnicki  <koriakin@0x04.net>
+
+	* config/s390/s390.md (pool_section_start): Use switch_to_section
+	to select proper read-only data section instead of hardcoding .rodata.
+	(pool_section_end): Use switch_to_section to match the above.
+

This is ok if bootstrap and regression tests are clean. Thanks!

-Andreas-



The bootstrap and regression tests are indeed clean for this patch and #2. I don't have commit access to gcc repo, how do I get this pushed?

Marcin KoÅcielnicki


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]