This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] PR48344: Fix unrecognizable insn error when gcc


On 01/20/2016 04:51 PM, Bernd Schmidt wrote:


On 01/20/2016 10:49 PM, Kelvin Nilsen wrote:

     * toplev.c (do_compile): remove invocation of process_options ()
         from within do_compile ()
     (toplev::main): insert invocation of process_options () before
         invocation of handle_common_deferred_options ().

The ChangeLog seems badly formatted, but it could have been eaten by
your mailer. You might want to include it as part of the attachment to
avoid whitespace damage.

As for the patch itself, it makes me a little nervous - it's hard to
judge whether this could have unintended consequences where something
relies on the existing ordering. I'd much rather postpone the generation
of stack_limit_rtx until rtl initialization time. Maybe this needs to be
per-function anyway, can Pmode change with attribute target?
I couldn't ever get past my own nervousness about this patch either. If there isn't a need for stack_limit_rtx early, then delaying that initialization seems wiser.

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]