This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] libstdc++/60637 Fix C++98 std::signbit<long double>
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: libstdc++ at gcc dot gnu dot org
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 18 Jan 2016 21:00:31 +0000
- Subject: Re: [patch] libstdc++/60637 Fix C++98 std::signbit<long double>
- Authentication-results: sourceware.org; auth=none
- References: <20160118162856 dot GY15084 at redhat dot com> <alpine dot DEB dot 2 dot 20 dot 1601182113270 dot 1874 at laptop-mg dot saclay dot inria dot fr>
On 18/01/16 21:24 +0100, Marc Glisse wrote:
On Mon, 18 Jan 2016, Jonathan Wakely wrote:
This fixes PR60637 by using the appropriate built-in for the size of
the argument type. In Bugzilla Marc asked why we don't just use the
same code as for C++11, but I want to make this less intrusive change
on the branches (trunk is already OK anyway).
That's fine for the branch indeed, but I don't see why we couldn't
remove that illegal signbit declaration on trunk in C++98 mode. It
works but it is still wrong to have it. Now that C++14 is the default,
explicitly asking for C++98 looks like a clear sign to me that people
don't want such extensions.
For -std=c++98 rather than -std=gnu++98 I agree, but I'm not going to
make that change in stage 3, let's do it in stage 1.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69350