This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C/C++ PATCH] Don't emit invalid VEC_COND_EXPR for vector comparisons (PR c/68062)
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Marek Polacek <polacek at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Richard Biener <rguenther at suse dot de>, Jason Merrill <jason at redhat dot com>
- Date: Wed, 13 Jan 2016 23:11:52 +0000
- Subject: Re: [C/C++ PATCH] Don't emit invalid VEC_COND_EXPR for vector comparisons (PR c/68062)
- Authentication-results: sourceware.org; auth=none
- References: <20160113152650 dot GJ25528 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1601131852060 dot 17296 at digraph dot polyomino dot org dot uk> <20160113195616 dot GL25528 at redhat dot com>
On Wed, 13 Jan 2016, Marek Polacek wrote:
> On Wed, Jan 13, 2016 at 06:53:06PM +0000, Joseph Myers wrote:
> > Will -Wsign-compare warnings be generated for the implicit signed /
> > unsigned conversions in comparisons, as for scalar comparisons?
>
> Good point. No, with the previous patch -Wsign-compare would be quiet. But
> since it probably should warn, I've added the warning (warn_for_sign_compare
> isn't prepared to handle vectors so I've just used warning_at).
>
> Regtested on x86_64-linux, bootstrap in progress, but I don't expect any
> problems.
The C front-end changes are OK.
--
Joseph S. Myers
joseph@codesourcery.com