This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, testsuite] Fix g++.dg/pr67989.C test failure when running with -march or -mcpu


On 01/12/2016 08:55 AM, Thomas Preud'homme wrote:
On Monday, January 11, 2016 04:57:18 PM Bernd Schmidt wrote:
On 01/08/2016 10:33 AM, Thomas Preud'homme wrote:
2016-01-08  Thomas Preud'homme  <thomas.preudhomme@arm.com>

          * g++.dg/pr67989.C: Remove ARM-specific option.
          * gcc.target/arm/pr67989.C: New file.

I checked some other arm tests and they have things like

/* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
"-march=*" } { "-march=armv4t" } } */
/* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
"-mthumb" } { "" } } */

Do you need the same in your testcase?

That was the first approach I took but Kyrill suggested me to use arm_arch_v4t
and arm_arch_v4t_ok machinery instead. It should take care about whether the
architecture can be selected.

Hmm, the ones I looked at did use dg-add-options, but not the corresponding _ok requirement. So I think this is OK.


Bernd


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]