This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, fortran] PR67779 - Strange ordering with strings in extended object
- From: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- To: Arjen Markus <arjen dot markus895 at gmail dot com>, "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 10 Jan 2016 14:14:53 +0100
- Subject: Re: [Patch, fortran] PR67779 - Strange ordering with strings in extended object
- Authentication-results: sourceware.org; auth=none
- References: <CAGkQGiLDNhmQxnfOgbKDJL-VtKPDrAOPzWXLeCpSUkoAuQzGyQ at mail dot gmail dot com>
Dear All,
The patch applies cleanly to 5-branch and fixes the problem. I will
commit it later on today, at the same time as the first batch of
deferred character fixes unless there are any objections.
Cheers
Paul
On 10 January 2016 at 14:02, Paul Richard Thomas
<paul.richard.thomas@gmail.com> wrote:
> Dear All,
>
> I had already posted a patch for the above, which sets the offset
> correctly in the caller to gfc_conv_expr_descriptor. However, I was so
> concerned that the latter was not doing the job properly that I
> decided to investigate further. The result was that I found a
> completely trivial omission in the condition for the calculation of
> 'base', which meant that the wrong branch was taken and the offset
> incorrectly calculated.
>
> Committed as 'obvious' (well... it took a while but is obvious now I
> see it!) in revision 232200.
>
> Thanks for the report, Arjen.
>
> Paul
--
The difference between genius and stupidity is; genius has its limits.
Albert Einstein