This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/4] Un-XFAIL ssa-dom-cse-2.c for most platforms


On 24/12/15 19:59, Mike Stump wrote:
On Dec 22, 2015, at 8:00 AM, Alan Lawrence <alan.lawrence@foss.arm.com> wrote:
On 21/12/15 15:33, Bill Schmidt wrote:

Not on a stage1 compiler - check_p8vector_hw_available itself requires being
able to run executables - I'll check on gcc112. However, both look like they're
really about the host (ability to execute an asm instruction), not the target
(/ability for gcc to output such an instruction)....

Hm, that looks like a pervasive problem for powerpc.  There are a number
of things that are supposed to be testing effective target but rely on
check_p8vector_hw_available, which as you note requires executing an
instruction and is really about the host.  We need to clean that up; I
should probably open a bug.  Kind of amazed this has gotten past us for
a couple of years.

Well, I was about to apologize for making a bogus remark. A really "proper" setup, would be to tell dejagnu to run your execution tests in some kind of emulator/simulator (on your host, perhaps one kind of powerpc) that only/additionally runs instructions for the other, _target_, kind of powerpc...and whatever setup you'd need for all that probably does not live in the GCC repository!

I’m not following.  dejagnu can already run tests on the target to makes decisions on which tests to run and what to expect from them, if it wants.  Some ports already do this.  Further, this is pretty typical and standard and easy to do

You confuse the issue by mentioning host, but this I think is wrong.  These decisions have nothing to do with the host.  The are properties of the target execution environment.

I’d be happy to help if you’d like.  I’d just need the details of what you’d like help with.

You're right, which is why I described my first (wrong) remark as bogus. That is, check_p8vector_hw_available is executing an assembly instruction, and on a well-configured test setup, that would potentially invoke an emulator etc. - whereas I am just doing 'native' testing on gcc110/gcc112 on the compile farm.

So (as Mike says) there is no bug here, but one just needs to be aware that passing -mcpu=power7 (say) is not sufficient to make check_p8vector_hw_available return false when executing on a power8 host; you would also need to set up some kind of power7 emulator/simulator.

Hope that's clear!

Thanks,
Alan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]