This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: update_vtable_references segfault


On 12/12/15 09:44, Nathan Sidwell wrote:
On 12/11/15 13:15, Jan Hubicka wrote:
Jan,

b) augment can_replace_by_local_alias_in_vtable to check whether
aliases can be created?

I think this is best: can_replace_by_local_alias_in_vtable exists to prevent the
body walk in cases we are not going to create the alias.  This is because in LTO
we may need to stream in the constructor from the object file that is not
copletely
free and thus it is better to not touch it unless necessary.

I went with augmenting can_replace_by_local_alias, which
can_replace_by_local_alias_in_vtable calls.  I also noticed that both should be
static, which  I suspect will encourage the inliner to go inline them and then
determine a bunch of code is unreachable.

tested on x86-linux and ptx-none.

ok?

https://gcc.gnu.org/ml/gcc-patches/2015-12/msg01324.html

ping?

nathan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]