This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 4/7][ARM] Add ACLE feature macro for ARMv8.1 instructions.
- From: Ramana Radhakrishnan <ramana dot gcc at googlemail dot com>
- To: Matthew Wahab <matthew dot wahab at foss dot arm dot com>
- Cc: Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>, Christian Bruel <christian dot bruel at st dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 15 Dec 2015 21:08:05 +0000
- Subject: Re: [PATCH 4/7][ARM] Add ACLE feature macro for ARMv8.1 instructions.
- Authentication-results: sourceware.org; auth=none
- References: <56572B79 dot 9000406 at foss dot arm dot com> <56572CEA dot 6020805 at foss dot arm dot com> <5665AECD dot 8050106 at foss dot arm dot com> <56668AA1 dot 5080103 at st dot com> <CAJA7tRYCXyGKUxUX-KR9QUZYnbbR9EPc-1d0M3RKhf54Th-kag at mail dot gmail dot com> <567039B5 dot 3010504 at foss dot arm dot com>
On Tue, Dec 15, 2015 at 4:03 PM, Matthew Wahab
<matthew.wahab@foss.arm.com> wrote:
> On 10/12/15 10:45, Ramana Radhakrishnan wrote:
>>
>> On Tue, Dec 8, 2015 at 7:45 AM, Christian Bruel <christian.bruel@st.com>
>> wrote:
>>>
>>> Hi Matthew,
>>>>
>>>>
>>>> On 26/11/15 16:01, Matthew Wahab wrote:
>>>>>
>>>>>
>>>>> Hello,
>>>>>
>>>>> This patch adds the feature macro __ARM_FEATURE_QRDMX to indicate the
>>>>> presence of the ARMv8.1 instructions vqrdmlah and vqrdmlsh. It is
>>>>> defined when the instructions are available, as it is when
>>>>> -march=armv8.1-a is enabled with suitable fpu options.
>>>>>
>>>>> gcc/
>>>>> 2015-11-26 Matthew Wahab <matthew.wahab@arm.com>
>>>>>
>>>>> * config/arm/arm-c.c (arm_cpu_builtins): Define
>>>>> __ARM_FEATURE_QRDMX.
>>>>>
>>>>
>>>
>>> + if (TARGET_NEON_RDMA)
>>> + builtin_define ("__ARM_FEATURE_QRDMX");
>>> +
>>>
>>> Since it depends on TARGET_NEON, could you please use
>>>
>>> def_or_undef_macro (pfile, "__ARM_FEATURE_QRDMX", TARGET_NEON_RDMA);
>>>
>>> instead ?
>>
>>
>> I think that's what it should be -
>>
>> OK with that fixed.
>
>
> Attached an updated patch using the def_or_undef macro. It also removes some
> trailing whitespace in that part of the code.
>
> Still ok?
Yep, OK.
regards
Ramana
> Matthew
>
> gcc/
> 2015-12-14 Matthew Wahab <matthew.wahab@arm.com>
>
> * config/arm/arm-c.c (arm_cpu_builtins): Define
> __ARM_FEATURE_QRDMX. Clean up some trailing whitespace.
>
>