This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[committed] Adjust nvptx-related test annotations


Hello,

I have committed the following testsuite patch as obvious.

On NVPTX, __builtin_apply does not work because in emitted assembly all calls
(including indirect) are annotated with expected function prototype.  As a
result, "untyped_assembly" effective-target test was added to skip tests with
__builtin_apply on NVPTX.  This patch corrects two instances where a wrong
test was used: one test checked for "alloca" instead, and the other hard-coded
the target triplet.

Noticed while testing NVPTX with alloca provided under -msoft-stack.

	* gcc.dg/builtin-return-1.c: Correct effective-target test.
	* gcc.dg/stack-usage-2.c: Use effective-target test.

Index: gcc.dg/builtin-return-1.c
===================================================================
--- gcc.dg/builtin-return-1.c	(revision 231608)
+++ gcc.dg/builtin-return-1.c	(working copy)
@@ -2,7 +2,7 @@
 /* Originator: Andrew Church <gcczilla@achurch.org> */
 /* { dg-do run } */
 /* { dg-xfail-run-if "PR36571 untyped return is char register" { "avr-*-*" } { "*" } { "" } } */
-/* { dg-require-effective-target alloca } */
+/* { dg-require-effective-target untyped_assembly } */
 /* This used to fail on SPARC because the (undefined) return
    value of 'bar' was overwriting that of 'foo'.  */
 
Index: gcc.dg/stack-usage-2.c
===================================================================
--- gcc.dg/stack-usage-2.c	(revision 231608)
+++ gcc.dg/stack-usage-2.c	(working copy)
@@ -1,7 +1,6 @@
 /* { dg-do compile } */
 /* { dg-options "-Wstack-usage=512" } */
-/* nvptx gets very upset with mismatched function types.  */
-/* { dg-skip-if "" { nvptx-*-* } { "*" } { "" } } */
+/* { dg-require-effective-target untyped_assembly } */
 
 int foo1 (void)  /* { dg-bogus "stack usage" } */
 {


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]