This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] gcc: read -fdebug-prefix-map OLD from environment (improved reproducibility)

From: Bernd Schmidt <bschmidt at redhat dot com>
To: Daniel Kahn Gillmor <dkg at fifthhorseman dot net>, Joseph Myers <joseph at codesourcery dot com>
Cc: gcc-patches at gcc dot gnu dot org, rb-general at lists dot reproducible-builds dot org, anthraxx at archlinux dot org, niels at thykier dot net
Date: Fri, 11 Dec 2015 18:03:28 +0100
Subject: Re: [PATCH] gcc: read -fdebug-prefix-map OLD from environment (improved reproducibility)
Authentication-results: sourceware.org; auth=none
References: <87egf1mxfl dot fsf at alice dot fifthhorseman dot net> <1449768978-3872-1-git-send-email-dkg at fifthhorseman dot net> <alpine dot DEB dot 2 dot 10 dot 1512102357320 dot 14974 at digraph dot polyomino dot org dot uk> <87h9jpkfli dot fsf at alice dot fifthhorseman dot net> <87si39gcc0 dot fsf at alice dot fifthhorseman dot net>

On 12/11/2015 05:49 PM, Daniel Kahn Gillmor wrote:

I've re-rolled the patch (attached below, here) to use the ENV: prefix
instead of the $.

It might be irrelevant at this point, but the "ENV:" prefix is used inAmigaOS and could be part of a filename.

+  if (0 == strncmp(ENV_PREFIX, arg, ENV_PREFIX_OFFSET))
+    {
+      env = xstrndup (arg+ENV_PREFIX_OFFSET, p - (arg+ENV_PREFIX_OFFSET));

Spaces before ( and around operators like +. Please review our codingguidelines and have a look at the surrounding code.

Wouldn't it be simpler just to special-case -fdebug-prefix-map ingen_producer_string? The environment variable thing strikes me asunnecessary.



Bernd

Follow-Ups:
- Re: [PATCH] gcc: read -fdebug-prefix-map OLD from environment (improved reproducibility)
  - From: Daniel Kahn Gillmor

References:
- [PATCH] gcc: read -fdebug-prefix-map OLD from environment (improved reproducibility)
  - From: Daniel Kahn Gillmor
- Re: [PATCH] gcc: read -fdebug-prefix-map OLD from environment (improved reproducibility)
  - From: Joseph Myers
- Re: [PATCH] gcc: read -fdebug-prefix-map OLD from environment (improved reproducibility)
  - From: Daniel Kahn Gillmor
- Re: [PATCH] gcc: read -fdebug-prefix-map OLD from environment (improved reproducibility)
  - From: Daniel Kahn Gillmor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]